xiangfu0 commented on PR #18687: URL: https://github.com/apache/pinot/pull/18687#issuecomment-4655006263
Follow-up update: both `StreamMetadataProvider.computePartitionGroupMetadata(...)` overloads are now abstract. Kafka 3.0/4.0, Pulsar, Kinesis, and the fake stream provider all explicitly implement the 5-arg overload now. For Kafka the 5-arg method preserves the previous `forceGetOffsetFromStream` behavior by calling the Kafka-owned 4-arg implementation with either current statuses or an empty status list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
