siddharthteotia commented on a change in pull request #4790: Support ORDER BY
for DISTINCT queries
URL: https://github.com/apache/incubator-pinot/pull/4790#discussion_r348101943
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
##########
@@ -454,6 +427,63 @@ private void setAggregationResults(BrokerResponseNative
brokerResponseNative,
}
}
+ private void setDistinctQueryResults(BrokerRequest brokerRequest,
BrokerResponseNative brokerResponseNative,
Review comment:
That seems like a pretty big PR which is still under review. If people
agree, may be we can merge this. What do you think @npawar ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
