siddharthteotia commented on a change in pull request #4790: Support ORDER BY for DISTINCT queries URL: https://github.com/apache/incubator-pinot/pull/4790#discussion_r348748290
########## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/BaseTable.java ########## @@ -35,21 +35,23 @@ final AggregationFunction[] _aggregationFunctions; final int _numAggregations; - final DataSchema _dataSchema; Review comment: Yes I have explained the rationale in DistinctTable code as to why this is needed. We don't have all the information available during deserialization of DistinctTable at the broker but the call to super constructor as to be made as the first line. Only after we deserialize do we get the schema ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
