goutamadwant commented on code in PR #19202:
URL: https://github.com/apache/pinot/pull/19202#discussion_r3755316208
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/ConfigUtils.java:
##########
@@ -33,6 +35,7 @@ private ConfigUtils() {
}
private static final Map<String, String> ENVIRONMENT_VARIABLES =
System.getenv();
+ private static final String CONFIG_PROVIDERS = "config.providers";
Review Comment:
@xiangfu0 Agreed. I replaced the provider-aware traversal in ConfigUtils
with a connector-neutral escape. A whole value beginning with `$${...}` becomes
the literal `${...}` for downstream processing, so ConfigUtils no longer knows
about Kafka or `config.providers`. Normal `${name:default}` behavior is
unchanged.
This is an upgrade-gated feature: all controllers and servers must be
upgraded before a provider-backed table config is applied. Older Pinot versions
cannot consume either form correctly, so the companion docs state that
requirement explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
