goutamadwant commented on code in PR #19202:
URL: https://github.com/apache/pinot/pull/19202#discussion_r3755329021
##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-3.0/src/main/java/org/apache/pinot/plugin/stream/kafka30/KafkaPartitionLevelConnectionHandler.java:
##########
@@ -166,7 +169,8 @@ private AdminClient
getOrCreateSharedAdminClientInternal(boolean isRetry) {
synchronized (this) {
ref = _sharedAdminClientRef;
if (ref == null) {
- ref =
KafkaAdminClientManager.getInstance().getOrCreateAdminClient(_consumerProp);
+ ref = KafkaAdminClientManager.getInstance()
+ .getOrCreateAdminClient(filterKafkaProperties(_consumerProp,
ADMIN_CLIENT_CONFIG_NAMES));
Review Comment:
@xiangfu0 confirmed and also called this out in the PR description. The
shared path filters through `AdminClientConfig.configNames()` plus the provider
namespace. All six cache-key fields remain included, so cache identity is
unchanged.
I also documented the separate rotation limitation: an existing shared
AdminClient keeps its current credentials until its references drop to zero and
the client is recreated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
