goutamadwant commented on code in PR #19202:
URL: https://github.com/apache/pinot/pull/19202#discussion_r3755332362
##########
pinot-spi/src/test/java/org/apache/pinot/spi/config/ConfigUtilsTest.java:
##########
@@ -56,6 +58,46 @@ public void testIndexingWithSystemProperties() {
System.clearProperty("AWS_SECRET_KEY");
}
+ @Test
+ public void testKafkaConfigProviderReferencesArePreserved() {
+ IndexingConfig indexingConfig = new IndexingConfig();
+ Map<String, String> streamConfigMap = new HashMap<>();
+ streamConfigMap.put("config.providers", "file");
+ streamConfigMap.put("ssl.keystore.password",
"${file:/vault/secrets/kafka.properties:keystore.password}");
+ streamConfigMap.put("ssl.truststore.password",
"${PINOT_KAFKA_TRUSTSTORE_PASSWORD:fallback}");
+ indexingConfig.setStreamConfigs(streamConfigMap);
+
+ IndexingConfig resolvedConfig =
+ ConfigUtils.applyConfigWithEnvVariablesAndSystemProperties(Map.of(),
indexingConfig);
+
+
assertEquals(resolvedConfig.getStreamConfigs().get("ssl.keystore.password"),
+ "${file:/vault/secrets/kafka.properties:keystore.password}");
+
assertEquals(resolvedConfig.getStreamConfigs().get("ssl.truststore.password"),
"fallback");
+ }
+
+ @Test
+ public void testConfigProviderReferencesAreScopedToDeclaringObject() {
Review Comment:
The provider-scoping design is gone with the Kafka-aware traversal.
ConfigUtils tests now cover generic escaped and unescaped substitution
directly. Kafka-side negative coverage now includes an undeclared alias, a
missing provider class, and `FileConfigProvider` without `allowed.paths`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
