xiangfu0 commented on PR #19664: URL: https://github.com/apache/pinot/pull/19664#issuecomment-6098253899
Second round addressed in b5d0ecb260; each of the 13 threads has a reply with what changed. On the items that were not posted inline: the `authorizeDeleteRows` duplication across the two basic-auth factories, the double `OPTION(...)` regex scan in IGNORE mode (the ALLOW path has always scanned twice as well) and the ZooKeeper principal map being rebuilt per check on a DELETE are left as they are, since each is either pre-existing or confined to a rare path, and I'd rather keep this PR's surface where it is. The guarded if-chain in `authorizeDelete` is now a sequence of fail-fast checks, in the same order. Validation on the pushed tree: `DeleteStatementTest`, `CalciteSqlCompilerTest`, `SqlOptionsModeTest`, `QueryOptionConfigListenerTest`, `RequestUtilsTest`, `SqlQueryExecutorTest`, `PinotClientRequestTest`, `BasicAuthAccessControlTest`, `ZkBasicAuthAccessControlFactoryTest`, `BrokerRequestHandlerDelegateTest`, `PinotQueryResourceTest` and `BasicAuthBatchIntegrationTest` pass locally; spotless, checkstyle and license checks pass on the touched modules. _🤖 Addressed by [Claude Code](https://claude.com/claude-code)_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
