xiangfu0 commented on PR #19664: URL: https://github.com/apache/pinot/pull/19664#issuecomment-6132472517
Third round addressed in de5d618d11; each of the 15 threads has a reply with what changed. Two items are documentation rather than code, on purpose: the controller applies no row-level security, which is now stated in the hook's and `authorizeDelete`'s Javadoc and in the description since executing a DELETE on the controller already requires overriding `createSqlQueryExecutor()` there; and the function deny-lists stay as lists, now cross-referenced with their definition sites, since a registry-level classification belongs in its own change. Validation on the pushed tree: the unit suites touched by the PR (parser, executor, broker request and basic-auth, controller resource, query logger) and `BasicAuthBatchIntegrationTest` pass locally; spotless, checkstyle and license checks pass on the touched modules; the warning-enabled compile reports nothing on added lines. The branch is rebased on current apache master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
