xiangfu0 commented on PR #19664: URL: https://github.com/apache/pinot/pull/19664#issuecomment-6135511956
Thanks for the review. Addressed in 7c3949e686, with a reply on each inline thread. On scope: agreed, the INSERT hardening is gone from this PR. The `sqlOptionsMode=IGNORE` and legacy `OPTION(...)` IGNORE rejections are keyed on DELETE again in both `CalciteSqlParser` and `RequestUtils`, `SqlOptionsModeTest` is back to asserting that an INSERT's options are dropped silently in those modes as before, and the Javadoc and description say DELETE. If we want INSERT to fail loudly too, that can be its own change. Validation on the pushed tree: the unit suites touched by the PR and `BasicAuthBatchIntegrationTest` pass locally; spotless, checkstyle and license checks pass on the touched modules; the warning-enabled compile reports nothing on added lines. _🤖 Addressed by [Claude Code](https://claude.com/claude-code)_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
