suvodeep-pyne commented on code in PR #19739:
URL: https://github.com/apache/pinot/pull/19739#discussion_r4320908392
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1448,6 +1448,10 @@ public void ensureAllPartitionsConsuming(TableConfig
tableConfig, List<StreamCon
Preconditions.checkState(!_isStopping, "Segment manager is stopping");
String realtimeTableName = tableConfig.getTableName();
+ // The updater below runs again when the IdealState write fails (e.g. on a
version conflict), while the segment ZK
+ // metadata created by the failed attempt remains. Track the created
segments so that the next attempt still adds
+ // them to the IdealState.
+ Map<String, Boolean> newSegmentsCreated = new ConcurrentHashMap<>();
Review Comment:
Thanks. I kept the `Boolean`. Whether a segment is in the map is what
"created by an earlier attempt" means, so the value is just one flag, and the
`@param` on the overload documents it. A dedicated enum or record would add a
type for that single flag.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1915,7 +1938,8 @@ && new
LLCSegmentName(segmentEntry.getKey()).getPartitionGroupId() == partitionI
break;
}
}
- if (previousConsumingSegment == null) {
+ // A segment created for an OFFLINE, ONLINE or new partition has no
previous CONSUMING segment
Review Comment:
Left as is. As you noted in the follow-up, the comment right above the
condition explains why OFFLINE, ONLINE and new-partition segments are exempt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
