anshul98ks123 commented on code in PR #19716: URL: https://github.com/apache/pinot/pull/19716#discussion_r4336607985
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/RecordProcessingException.java: ########## @@ -0,0 +1,29 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.spi.creator; + +/// Thrown when segment creation fails to read or process a record of its input. +public class RecordProcessingException extends RuntimeException { Review Comment: Fixed in 70d6fa56ab: moved out of the SPI into pinot-segment-local, the only module that throws it. Minions and Spark see no change: it is a `RuntimeException` with the same messages. Telling record failures apart by stage instead would misread `build()` failures from disk or index I/O, whose messages can name controller paths. ########## pinot-core/src/main/java/org/apache/pinot/core/auth/FineGrainedAuthUtils.java: ########## @@ -132,7 +132,7 @@ public static void validateFineGrainedAuth(Method endpointMethod, UriInfo uriInf String errorMsg = "Failed to check for access for target type " + auth.targetType() + " and target ID " + targetId + " with action " + auth.action(); LOGGER.error(errorMsg, t); - throw new WebApplicationException(errorMsg, t, Response.Status.INTERNAL_SERVER_ERROR); + throw new WebApplicationException(errorMsg, Response.Status.INTERNAL_SERVER_ERROR); Review Comment: Fixed in 70d6fa56ab: reverted, so pinot-core is untouched. With opt-in, the auth 500 never carries causes. The broker's mapper returns only `t.getMessage()`, so broker responses would not have changed anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
