anshul98ks123 commented on code in PR #19716:
URL: https://github.com/apache/pinot/pull/19716#discussion_r4360402161
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotIngestionRestletResource.java:
##########
@@ -236,6 +239,17 @@ private SuccessResponse ingestData(String
tableNameWithType, String batchConfigM
return fileIngestionHelper.buildSegmentAndPush(payload);
}
+ /// A record failure returns its causes, which describe the uploaded data.
Other failures don't: they can involve
+ /// files on the controller that the batch config names.
+ @VisibleForTesting
+ static ControllerApplicationException newIngestFromFileException(String
message, Response.Status status,
+ Exception e) {
+ if (ExceptionUtils.indexOfType(e, RecordProcessingException.class) >= 0) {
Review Comment:
Fixed in 35c1a42bc7: the response chain now starts at the
`RecordProcessingException` (found with `throwableOfType`), and the
wrapped-failure test pins that a working-dir wrapper above it stays out.
`FileIngestionHelper` still logs the full exception.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotIngestionRestletResource.java:
##########
@@ -43,6 +44,7 @@
import javax.ws.rs.core.HttpHeaders;
import javax.ws.rs.core.MediaType;
import javax.ws.rs.core.Response;
+import org.apache.commons.lang3.exception.ExceptionUtils;
Review Comment:
Fixed in 35c1a42bc7: called inline as
`org.apache.commons.lang3.exception.ExceptionUtils.throwableOfType(...)`, and
the import is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
