xiangfu0 commented on PR #20035: URL: https://github.com/apache/pinot/pull/20035#issuecomment-6480556215
Addressed the performance follow-up in df653c2d17e2cd833b110ff50d570892c4f5b26c, rebased onto current master before editing. - Empty hints use Map.of(); singleton eligibility and matching avoid copied maps and recursive hashing, with an immediate exit on a missing column. Multiple hints check distinct target columns and stop when none remain. - Function-name/arity gating avoids structural lookups for unrelated expressions; identity tracking remains unchanged. - Aggregation preparation reuses the existing list, unchanged pairs, and map storage, while rehashing mutable FILTER keys. Original SELECT slots remain fixed. HAVING now short-circuits the trim comparison, and the initial deduplication set is conditional. - Unsupported non-identifier targets fail the requested precondition before segment scanning. Existing producers use identifiers. The wire representation is unchanged; downstream empty-map test fixtures are updated in startree-pinot #5093. Validation on JDK 25: **76 focused tests passed**, with zero failures/errors/skips; fresh production/test compilation and all four scoped checks passed. Independent source review found no actionable issues. These are source-backed reductions in work/allocation; no new latency or benchmark claim is made. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
