xiangfu0 commented on PR #20035: URL: https://github.com/apache/pinot/pull/20035#issuecomment-6482708353
Addressed all five follow-up suggestions in faa46f1388887d7dcb750727c90c6a1c97e9a575: - Singleton conversion uses Map.of(); full-availability multi-hint queries reuse the original map. - The aggregation FILTER pass is guarded by the existing flag, with separate predicate traversal retained. - Single-key GROUP BY/ORDER BY comparison uses direct equality; other sizes retain set semantics. - Extra aggregation-candidate lists are allocated only for HAVING/ORDER BY, preserving fixed SELECT slots. JDK 25 validation: **77 focused tests passed**, zero failures/errors/skips; fresh production/test compilation and all four scoped checks passed. Independent source review found no actionable issues. Identity tracking, full required-column extraction, and FILTER-key rehashing are unchanged. These are source-backed reductions in work/allocation; the earlier benchmark remains historical. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
