xiangfu0 commented on PR #20035: URL: https://github.com/apache/pinot/pull/20035#issuecomment-6458597557
Addressed the latest review in 62abc9a0e2f031c53c01131cea14e67bd66bcb52: - ORDER BY keeps its existing wrapper when the expression root is unchanged. Replaced roots use the three-argument constructor, preserving `isNullsLast()` and direction. - Constant TRUE/FALSE FILTER contexts return before predicate access. - Removed the redundant retained-aggregation-root traversal and public `getAggregationFunctionContexts()` getter. The separate FILTER-context walk remains through the existing filtered-aggregation accessor; original aggregation slots remain private and fixed. - Applicable hints are filtered once into a private map against columns present on every selected segment. Recursive rewriting uses that map and the identity tracker, leaving the original hint map intact. - Kept selective identity-based recompilation and eager initial preparation. Reuse tests now compare individual aggregation-function instances rather than the containing array. Validation on JDK 25: **74 tests passed**, no failures/errors/skips—41 rewrite cases, 12 instance-planner cases, 15 converter cases, and 6 real timestamp-query cases. Coverage includes actual constant filters in both null modes, all four explicit NULLS/direction combinations with unrelated/root/nested rewrites, original hint-map preservation, and existing mixed-index execution with prefetch. All scoped formatting/license/Checkstyle checks passed; independent source review found no actionable issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
