icefury71 commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360535885
########## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/IsNullPredicateAstNode.java ########## @@ -0,0 +1,85 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.pql.parsers.pql2.ast; + +import java.util.Collections; +import org.apache.pinot.common.request.Expression; +import org.apache.pinot.common.request.FilterOperator; +import org.apache.pinot.common.utils.request.FilterQueryTree; +import org.apache.pinot.common.utils.request.HavingQueryTree; +import org.apache.pinot.common.utils.request.RequestUtils; +import org.apache.pinot.pql.parsers.Pql2CompilationException; + + +/** + * AST node for IS predicates (foo IS NULL, foo IS NOT NULL). + */ +public class IsNullPredicateAstNode extends PredicateAstNode { + + private final boolean _isNegation; + + public IsNullPredicateAstNode(boolean notNodeExists) { + _isNegation = notNodeExists; + } + + @Override + public void addChild(AstNode childNode) { + if (childNode instanceof IdentifierAstNode) { + if (_identifier == null) { + _identifier = ((IdentifierAstNode) childNode).getName(); + } else { + throw new Pql2CompilationException("Only one column supported in IS predicate."); + } + } else if (childNode instanceof FunctionCallAstNode) { + throw new Pql2CompilationException("Function not supported in IS predicate"); + } else if (childNode instanceof LiteralAstNode) { + throw new Pql2CompilationException("Constants not supported in IS predicate"); + } + + // Add the child nonetheless + super.addChild(childNode); Review comment: will move this to the final else part (as is done in other predicate ast node classes) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
