icefury71 commented on a change in pull request #4943: Adding basic null 
predicate support
URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360574352
 
 

 ##########
 File path: 
pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java
 ##########
 @@ -111,6 +113,15 @@ private static BaseFilterOperator 
constructPhysicalOperator(FilterQueryTree filt
       // Leaf filter operator
       Predicate predicate = Predicate.newPredicate(filterQueryTree);
 
+      // Check for null predicate
+      Predicate.Type type = predicate.getType();
 
 Review comment:
   Yeah - couldn't figure out how to do this in predicate evaluator. Leaving it 
as is for now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to