Jackie-Jiang commented on a change in pull request #4943: Adding basic null
predicate support
URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360548796
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java
##########
@@ -111,6 +113,15 @@ private static BaseFilterOperator
constructPhysicalOperator(FilterQueryTree filt
// Leaf filter operator
Predicate predicate = Predicate.newPredicate(filterQueryTree);
+ // Check for null predicate
+ Predicate.Type type = predicate.getType();
Review comment:
I think it is a little bit hard to model NULL into PredicateEvaluator
though, as there is no easy way to hook the nullValueVector into it. I'm okay
making this an extra check for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
