fx19880617 commented on a change in pull request #5005: Make calcite parser support order by expression URL: https://github.com/apache/incubator-pinot/pull/5005#discussion_r370418278
########## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ########## @@ -111,6 +112,7 @@ private static void setOptions(PinotQuery pinotQuery, List<String> optionsStatem private static PinotQuery compileCalciteSqlToPinotQuery(String sql) { SqlParser.ConfigBuilder parserBuilder = SqlParser.configBuilder(); parserBuilder.setLex(PINOT_LEX); + parserBuilder.setConformance(SqlConformanceEnum.LENIENT); Review comment: basically calcite parser cannot parse `LIMIT X,Y` until this conformance is added. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org