siddharthteotia commented on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577945733 > > This is supported on all paths right? > > (1) PQL -> PqlCompiler -> BrokerRequest > > (2) PQL -> PqlCompiler -> BrokerRequest -> PinotQuery -> brokerRequest.setPinotQuery() > > (3) SQL -> Calcite parser -> PinotQuery > > For path 3 it's SQL -> Calcite parser -> PinotQuery -> BrokerRequest > Query processing still depends on BrokerRequest. Just to be on the same page (and this is not really related to this PR), for path 3, once we have the PinotQuery, we are only going to set it inside BrokerRequest -- we are not going to build a full fledged broker request all together by converting PinotQuery to BrokerRequest. So the desired end state here is to have the BrokerRequest as just a wrapper thrift definition over PinotQuery and the servers should build their execution plan from the information stored in brokerRequest.getPinotQuery() -- this should be sufficient to build the plan. In fact, since PinotQuery is a thrift object on its own, we should be sending that to the servers and migrate each and every operator to work off PinotQuery -> QueryContext as described in this doc
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
