fx19880617 commented on a change in pull request #5005: Calcite SQL compiler
syntax support for order by expression and Limit offset, count.
URL: https://github.com/apache/incubator-pinot/pull/5005#discussion_r370421179
##########
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##########
@@ -111,6 +112,7 @@ private static void setOptions(PinotQuery pinotQuery,
List<String> optionsStatem
private static PinotQuery compileCalciteSqlToPinotQuery(String sql) {
SqlParser.ConfigBuilder parserBuilder = SqlParser.configBuilder();
parserBuilder.setLex(PINOT_LEX);
+ parserBuilder.setConformance(SqlConformanceEnum.LENIENT);
Review comment:
> This is supported on all paths right?
>
> (1) PQL -> PqlCompiler -> BrokerRequest
> (2) PQL -> PqlCompiler -> BrokerRequest -> PinotQuery ->
brokerRequest.setPinotQuery()
> (3) SQL -> Calcite parser -> PinotQuery
For path 3 it's SQL -> Calcite parser -> PinotQuery -> BrokerRequest
Query processing still depends on BrokerRequest.
Also plan to make query console default to go through path 3 in PR
https://github.com/apache/incubator-pinot/pull/4994
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
