codecov-io edited a comment on issue #4995: Decouple server instance id with hostname/port config. URL: https://github.com/apache/incubator-pinot/pull/4995#issuecomment-575972107 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4995?src=pr&el=h1) Report > Merging [#4995](https://codecov.io/gh/apache/incubator-pinot/pull/4995?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/29c6b39d34d51bb4165b0be63b17a427a45ebf52?src=pr&el=desc) will **increase** coverage by `6.83%`. > The diff coverage is `70.83%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4995?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4995 +/- ## ============================================ + Coverage 51.82% 58.65% +6.83% Complexity 12 12 ============================================ Files 1176 1181 +5 Lines 62388 63102 +714 Branches 9167 9287 +120 ============================================ + Hits 32331 37015 +4684 + Misses 27577 23363 -4214 - Partials 2480 2724 +244 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4995?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pinot/server/starter/helix/HelixServerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9IZWxpeFNlcnZlclN0YXJ0ZXIuamF2YQ==) | `49.48% <70.83%> (+49.48%)` | `0 <0> (ø)` | :arrow_down: | | [...ot/common/function/FunctionDefinitionRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vRnVuY3Rpb25EZWZpbml0aW9uUmVnaXN0cnkuamF2YQ==) | `44.44% <0%> (-35.56%)` | `0% <0%> (ø)` | | | [...config/instance/InstanceAssignmentConfigUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL2luc3RhbmNlL0luc3RhbmNlQXNzaWdubWVudENvbmZpZ1V0aWxzLmphdmE=) | `67.5% <0%> (-8.98%)` | `0% <0%> (ø)` | | | [...ot/parsers/utils/BrokerRequestComparisonUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wYXJzZXJzL3V0aWxzL0Jyb2tlclJlcXVlc3RDb21wYXJpc29uVXRpbHMuamF2YQ==) | `21.31% <0%> (-4.81%)` | `0% <0%> (ø)` | | | [...pache/pinot/common/utils/request/RequestUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvcmVxdWVzdC9SZXF1ZXN0VXRpbHMuamF2YQ==) | `81.54% <0%> (-3.69%)` | `0% <0%> (ø)` | | | [...ntroller/helix/core/rebalance/TableRebalancer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYmFsYW5jZS9UYWJsZVJlYmFsYW5jZXIuamF2YQ==) | `63.87% <0%> (-2.79%)` | `0% <0%> (ø)` | | | [...rg/apache/pinot/core/operator/CombineOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9Db21iaW5lT3BlcmF0b3IuamF2YQ==) | `66.29% <0%> (-2.25%)` | `0% <0%> (ø)` | | | [...mon/request/transform/TransformExpressionTree.java](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC90cmFuc2Zvcm0vVHJhbnNmb3JtRXhwcmVzc2lvblRyZWUuamF2YQ==) | `77.27% <0%> (-1.76%)` | `0% <0%> (ø)` | | | [...org/apache/pinot/spi/plugin/PluginClassLoader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvcGx1Z2luL1BsdWdpbkNsYXNzTG9hZGVyLmphdmE=) | `24.52% <0%> (-1.4%)` | `0% <0%> (ø)` | | | [.../java/org/apache/pinot/spi/data/TimeFieldSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9UaW1lRmllbGRTcGVjLmphdmE=) | `92.59% <0%> (-1.24%)` | `0% <0%> (ø)` | | | ... and [279 more](https://codecov.io/gh/apache/incubator-pinot/pull/4995/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4995?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4995?src=pr&el=footer). Last update [29c6b39...ef6ce8a](https://codecov.io/gh/apache/incubator-pinot/pull/4995?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
