Jackie-Jiang commented on a change in pull request #4995: Decouple server
instance id with hostname/port config.
URL: https://github.com/apache/incubator-pinot/pull/4995#discussion_r372120094
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.java
##########
@@ -266,7 +266,7 @@ private void updateInstanceConfigInHelix(Map<String,
String> props) {
_helixAdmin.setConfig(scope, props);
}
- private void addInstanceTagIfNeeded(String clusterName, String instanceName)
{
+ private void updateInstanceConfigIfNeeded(String clusterName, String
instanceName, Configuration serverConf) {
InstanceConfig instanceConfig = _helixAdmin.getInstanceConfig(clusterName,
instanceName);
List<String> instanceTags = instanceConfig.getTags();
if (instanceTags == null || instanceTags.size() == 0) {
Review comment:
That is why I suggested adding a flag to track whether we need to update and
write the instance config back to ZK. Each `_helixAdmin.addInstanceTag()` reads
the instance config and writes it back, which can be saved with the flag.
Overall we should only read the instance config once, and write it back once if
it needs to be updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
