chenboat commented on a change in pull request #4995: Decouple server instance
id with hostname/port config.
URL: https://github.com/apache/incubator-pinot/pull/4995#discussion_r372005508
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.java
##########
@@ -266,7 +266,7 @@ private void updateInstanceConfigInHelix(Map<String,
String> props) {
_helixAdmin.setConfig(scope, props);
}
- private void addInstanceTagIfNeeded(String clusterName, String instanceName)
{
+ private void updateInstanceConfigIfNeeded(String clusterName, String
instanceName, Configuration serverConf) {
InstanceConfig instanceConfig = _helixAdmin.getInstanceConfig(clusterName,
instanceName);
List<String> instanceTags = instanceConfig.getTags();
if (instanceTags == null || instanceTags.size() == 0) {
Review comment:
_helixAdmin.addInstanceTag() writes to zk. InstanceTag.add() does not do
that -- instanceTag is merely a reference. I do not think the former can be
simplified to latter. Did I miss anything here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
