haibow commented on a change in pull request #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r376175428
########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/SegmentMetadataImpl.java ########## @@ -43,19 +43,19 @@ import org.apache.commons.configuration.ConfigurationException; import org.apache.commons.configuration.PropertiesConfiguration; import org.apache.commons.lang.StringEscapeUtils; -import org.apache.pinot.spi.data.MetricFieldSpec; -import org.apache.pinot.spi.data.Schema; import org.apache.pinot.common.metadata.segment.RealtimeSegmentZKMetadata; import org.apache.pinot.common.segment.SegmentMetadata; import org.apache.pinot.common.segment.StarTreeMetadata; -import org.apache.pinot.spi.utils.JsonUtils; -import org.apache.pinot.spi.utils.TimeUtils; import org.apache.pinot.core.indexsegment.generator.SegmentVersion; import org.apache.pinot.core.segment.creator.impl.V1Constants; import org.apache.pinot.core.segment.creator.impl.V1Constants.MetadataKeys; import org.apache.pinot.core.segment.store.SegmentDirectoryPaths; import org.apache.pinot.core.startree.v2.StarTreeV2Constants; import org.apache.pinot.core.startree.v2.StarTreeV2Metadata; +import org.apache.pinot.spi.data.MetricFieldSpec; Review comment: Since the import order should be fixed and has been fixed, I would like to keep the change as is. Will avoid such changes in the future. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
