mcvsubbu commented on a change in pull request #4954: Support schema evolution
for consuming segments
URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r377987662
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -299,6 +311,23 @@ public long getMaxTime() {
return _maxTime;
}
+ public void addExtraColumns(Schema newSchema) {
+ Map<String, BaseDefaultColumnHandler.DefaultColumnAction>
defaultColumnActionMap =
Review comment:
Not sure why DefaultColumnAction is needed here. We can just iterate through
the schema and add a newly added column's FieldSpec if it is not there already.
The FieldSpec can have the null value. There is no question of handling
incompatible schema evolution at that point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
