mcvsubbu commented on a change in pull request #4954: Support schema evolution 
for consuming segments
URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r377987205
 
 

 ##########
 File path: 
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/IndexSegment.java
 ##########
 @@ -57,6 +58,13 @@
    */
   Set<String> getPhysicalColumnNames();
 
+  /**
+   * Returns all columns for the "select *" query
+   *
+   * @return Set of column names
+   */
+  Set<String> getColumnNamesForSelectStar();
 
 Review comment:
   Why are we treating newly added columns as virtual?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to