mcvsubbu commented on a change in pull request #4954: Support schema evolution
for consuming segments
URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r388584027
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/ColumnMetadata.java
##########
@@ -540,4 +560,31 @@ public String toString() {
return result.toString();
}
+
+ @Override
+ public boolean equals(Object object) {
+ if (this == object) {
+ return true;
+ }
+ if (object instanceof ColumnMetadata) {
+ ColumnMetadata columnMetadata = (ColumnMetadata) object;
+ return getColumnName() == columnMetadata.getColumnName() &&
getCardinality() == columnMetadata.getCardinality()
+ && getTotalDocs() == columnMetadata.getTotalDocs() &&
getDataType().equals(columnMetadata.getDataType())
+ && getBitsPerElement() == columnMetadata.getBitsPerElement() &&
getFieldSpec()
+ .equals(columnMetadata.getFieldSpec()) && isSorted() ==
columnMetadata.isSorted()
+ && hasNulls() == columnMetadata.hasNulls() && hasDictionary() ==
columnMetadata.hasDictionary()
Review comment:
you need deeper equals definition, make sure that the inverted index obects
are equal. etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
