Jackie-Jiang commented on a change in pull request #5137: Fix the ConstantValueDictionary URL: https://github.com/apache/incubator-pinot/pull/5137#discussion_r390739455
########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/ConstantValueDoubleDictionary.java ########## @@ -19,20 +19,25 @@ package org.apache.pinot.core.segment.index.readers; /** - * Dictionary for constant-value double + * Dictionary of a single double value. Review comment: I prefer the current comment because the dictionary only contains a single value, instead of multiple values of the same value. @mcvsubbu Opinion? Future plan would be wrap all these classes (forward index, inverted index, dictionary for default column) into one single class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
