mcvsubbu commented on a change in pull request #5137: Fix the ConstantValueDictionary URL: https://github.com/apache/incubator-pinot/pull/5137#discussion_r390983968
########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/ConstantValueDoubleDictionary.java ########## @@ -19,20 +19,25 @@ package org.apache.pinot.core.segment.index.readers; /** - * Dictionary for constant-value double + * Dictionary of a single double value. Review comment: I like the one class approach, and had suggested that earlier to Haibo. Let us not worry too much about a comment ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
