Jackie-Jiang commented on a change in pull request #5137: Fix the
ConstantValueDictionary
URL: https://github.com/apache/incubator-pinot/pull/5137#discussion_r390759640
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/column/BaseVirtualColumnProvider.java
##########
@@ -39,7 +39,7 @@
public DataFileReader buildReader(VirtualColumnContext context) {
if (context.getFieldSpec().isSingleValueField()) {
- return new ConstantSingleValueInvertedIndex(0);
+ return new ConstantSingleValueSortedIndex(0);
Review comment:
Because it is sorted index (sorted index can be used as both forward and
inverted index).
The multi-value one should be split into forward and inverted index, but
that is out of the scope of this pr, so will address later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
