mcvsubbu commented on a change in pull request #5147: Support default star-tree
URL: https://github.com/apache/incubator-pinot/pull/5147#discussion_r391956217
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/config/IndexingConfig.java
##########
@@ -145,6 +146,14 @@ public void setOnHeapDictionaryColumns(List<String>
onHeapDictionaryColumns) {
_onHeapDictionaryColumns = onHeapDictionaryColumns;
}
+ public boolean isEnableDefaultStarTree() {
+ return _enableDefaultStarTree;
+ }
+
+ public void setEnableDefaultStarTree(boolean enableDefaultStarTree) {
+ _enableDefaultStarTree = enableDefaultStarTree;
Review comment:
Another way to add this config may be to add a "mode" field in
StarTreeIndexConfig. If mode is set to "auto" then ignore other settings.
Otherwise, follow the other serttings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
