Jackie-Jiang commented on a change in pull request #5147: Support default
star-tree
URL: https://github.com/apache/incubator-pinot/pull/5147#discussion_r399875607
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/config/IndexingConfig.java
##########
@@ -145,6 +146,14 @@ public void setOnHeapDictionaryColumns(List<String>
onHeapDictionaryColumns) {
_onHeapDictionaryColumns = onHeapDictionaryColumns;
}
+ public boolean isEnableDefaultStarTree() {
Review comment:
This has to match the variable name (key of the config), and I prefer the
config to be `"enableDefaultStarTree": true`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
