Jackie-Jiang commented on a change in pull request #5147: Support default
star-tree
URL: https://github.com/apache/incubator-pinot/pull/5147#discussion_r391966122
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/config/IndexingConfig.java
##########
@@ -145,6 +146,14 @@ public void setOnHeapDictionaryColumns(List<String>
onHeapDictionaryColumns) {
_onHeapDictionaryColumns = onHeapDictionaryColumns;
}
+ public boolean isEnableDefaultStarTree() {
+ return _enableDefaultStarTree;
+ }
+
+ public void setEnableDefaultStarTree(boolean enableDefaultStarTree) {
+ _enableDefaultStarTree = enableDefaultStarTree;
Review comment:
I prefer the current way so that the default star-tree can be enabled by one
boolean flag. Don't want to change the existing StarTreeIndexConfig because
adding a mode seems more confusing to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
