Jackie-Jiang commented on a change in pull request #5176: Make text index query cache a configurable option URL: https://github.com/apache/incubator-pinot/pull/5176#discussion_r397383948
########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/IndexLoadingConfig.java ########## @@ -45,7 +45,7 @@ private ReadMode _readMode = ReadMode.DEFAULT_MODE; private List<String> _sortedColumns = Collections.emptyList(); private Set<String> _invertedIndexColumns = new HashSet<>(); - private Set<String> _textIndexColumns = new HashSet<>(); + private Map<String, Map<String, String>> _textIndexColumns = new HashMap<>(); Review comment: Don't put the whole map here. The map contains all the properties, not for text column only. I think you can keep this config unchanged, but check the field config when loading the text index. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
