Jackie-Jiang commented on a change in pull request #5176: Make text index query cache a configurable option URL: https://github.com/apache/incubator-pinot/pull/5176#discussion_r397380997
########## File path: pinot-common/src/main/java/org/apache/pinot/common/config/FieldConfig.java ########## @@ -32,9 +32,12 @@ public static String BLOOM_FILTER_COLUMN_KEY = "field.config.bloom.filter"; public static String ON_HEAP_DICTIONARY_COLUMN_KEY = "field.config.onheap.dictionary"; - public static String TEXT_INDEX_REALTIME_READER_REFRESH_KEY = "field.config.realtime.reader.refresh"; public static String VAR_LENGTH_DICTIONARY_COLUMN_KEY = "field.config.var.length.dictionary"; + // Lucene index properties + public static String LUCENE_TEXT_INDEX_REALTIME_READER_REFRESH_KEY = "field.config.text.index.realtime.reader.refresh"; Review comment: Not related to this but can we remove the `field.config.` prefix from all these keys? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
