siddharthteotia commented on a change in pull request #5177: Lucene DocId to
PinotDocId cache
URL: https://github.com/apache/incubator-pinot/pull/5177#discussion_r400358308
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/text/LuceneTextIndexReader.java
##########
@@ -148,8 +153,12 @@ private MutableRoaringBitmap
getPinotDocIds(MutableRoaringBitmap luceneDocIds) {
try {
while (luceneDocIDIterator.hasNext()) {
int luceneDocId = luceneDocIDIterator.next();
- Document document = _indexSearcher.doc(luceneDocId);
- int pinotDocId =
Integer.valueOf(document.get(LuceneTextIndexCreator.LUCENE_INDEX_DOC_ID_COLUMN_NAME));
+ Integer pinotDocId = _luceneDocIDToPinotDocIDCache.get(luceneDocId);
Review comment:
Also added a TODO to consider building mapping on-the-fly during query
processing -- we can have two methods and make it configurable based on number
of docs per segment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
