Jackie-Jiang commented on a change in pull request #5177: Lucene DocId to PinotDocId cache URL: https://github.com/apache/incubator-pinot/pull/5177#discussion_r400359941
########## File path: pinot-core/src/test/java/org/apache/pinot/queries/TestTextSearchQueries.java ########## @@ -89,7 +91,7 @@ private RecordReader _recordReader; Schema _schema; - private List<IndexSegment> _indexSegments = new ArrayList<>(1); + private static List<IndexSegment> _indexSegments = new ArrayList<>(1); Review comment: Revert the change in this file? Also suggesting rename the test to TextSearchQueriesTest for naming convention. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
