siddharthteotia commented on a change in pull request #5177: Lucene DocId to
PinotDocId cache
URL: https://github.com/apache/incubator-pinot/pull/5177#discussion_r400576876
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/converter/SegmentV1V2ToV3FormatConverter.java
##########
@@ -241,6 +242,22 @@ public boolean accept(File dir, String name) {
Files.copy(indexFile.toPath(), v3LuceneIndexFile.toPath());
}
}
+ // if segment reload is issued asking for up-conversion of
Review comment:
Lucene index files (created by Lucene) can't be copied as done in
copyForwardIndex
`PinotDataBuffer oldBuffer = reader.getIndexFor(column, indexType);
long oldBufferSize = oldBuffer.size();
PinotDataBuffer newBuffer = writer.newIndexFor(column, indexType,
oldBufferSize);
oldBuffer.copyTo(0, newBuffer, 0, oldBufferSize);`
The only thing that can be copied as buffer is the mapping file that we
create. I just wanted to keep everything related to lucene in a single method.
I can explore how to clean this up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
