Jackie-Jiang commented on a change in pull request #5177: Lucene DocId to
PinotDocId cache
URL: https://github.com/apache/incubator-pinot/pull/5177#discussion_r400580427
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/converter/SegmentV1V2ToV3FormatConverter.java
##########
@@ -241,6 +242,22 @@ public boolean accept(File dir, String name) {
Files.copy(indexFile.toPath(), v3LuceneIndexFile.toPath());
}
}
+ // if segment reload is issued asking for up-conversion of
Review comment:
I was referring to the usage (check metadata and copy instead of filtering
on file names). Not critical, you can address later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
