siddharthteotia commented on a change in pull request #5177: Lucene DocId to 
PinotDocId cache
URL: https://github.com/apache/incubator-pinot/pull/5177#discussion_r400578880
 
 

 ##########
 File path: 
pinot-core/src/main/java/org/apache/pinot/core/segment/index/converter/SegmentV1V2ToV3FormatConverter.java
 ##########
 @@ -241,6 +242,22 @@ public boolean accept(File dir, String name) {
         Files.copy(indexFile.toPath(), v3LuceneIndexFile.toPath());
       }
     }
+    // if segment reload is issued asking for up-conversion of
 
 Review comment:
   Added a TODO -- I have couple of more PRs coming up for text. Will address 
this

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to