mcvsubbu commented on a change in pull request #5175: add pinot upsert features
to pinot common
URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r401996265
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -378,4 +407,23 @@ public ServerType getServerType() {
@Deprecated
public static final String TABLE_NAME = "segment.table.name";
}
+
+ public enum UpdateSemantic {
+ APPEND,
Review comment:
Please add comments on each of these. What does APPEND mean, vs what UPSERT
means. Feel free to point to the design doc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
