jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r402613815
########## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java ########## @@ -59,13 +65,28 @@ private static final Logger LOGGER = LoggerFactory.getLogger(Schema.class); private String _schemaName; + + // upsert related config + // primary key refers to the column name that is the primary key of this upsert table + private String _primaryKey; Review comment: @kishoreg @ChethanUK I have changed the primary key in schema config to be a list instead of a single string. For now we are still performing check to ensure that primary key will be one and only one. However we should be able to change that once we have mulitple-primary-key support in place ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
