mcvsubbu commented on a change in pull request #5589:
URL: https://github.com/apache/incubator-pinot/pull/5589#discussion_r442338555
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java
##########
@@ -199,11 +199,13 @@ public void stop() {
if (queryLogRateLimiter.tryAcquire() || forceLog(schedulerWaitMs,
numDocsScanned)) {
LOGGER.info(
- "Processed
requestId={},table={},segments(queried/processed/matched/consuming)={}/{}/{}/{},"
- +
"schedulerWaitMs={},totalExecMs={},totalTimeMs={},minConsumingFreshnessMs={},broker={},"
- + "numDocsScanned={},scanInFilter={},scanPostFilter={},sched={}",
- requestId, tableNameWithType, numSegmentsQueried,
numSegmentsProcessed, numSegmentsMatched,
- numSegmentsConsuming, schedulerWaitMs,
timerContext.getPhaseDurationMs(ServerQueryPhase.QUERY_PROCESSING),
+ "Processed
RequestId:{},table:{},segments(queried/processed/matched/consuming)={}/{}/{}/{},"
+ +
"schedulerWaitMs:{},reqDeserMs:{},totalExecMs:{},resSerMs:{},totalTimeMs:{},minConsumingFreshnessMs:{},broker:{},"
Review comment:
Can you add the new items at the end and not change the names of the
variables? Is the changing of var names absolutely needed?
If we are trying to minimize the line length, another way of doing this will
be to create a separate logger that outputs in binary, and provide a utility to
read it?
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java
##########
@@ -199,11 +199,13 @@ public void stop() {
if (queryLogRateLimiter.tryAcquire() || forceLog(schedulerWaitMs,
numDocsScanned)) {
LOGGER.info(
- "Processed
requestId={},table={},segments(queried/processed/matched/consuming)={}/{}/{}/{},"
- +
"schedulerWaitMs={},totalExecMs={},totalTimeMs={},minConsumingFreshnessMs={},broker={},"
- + "numDocsScanned={},scanInFilter={},scanPostFilter={},sched={}",
- requestId, tableNameWithType, numSegmentsQueried,
numSegmentsProcessed, numSegmentsMatched,
- numSegmentsConsuming, schedulerWaitMs,
timerContext.getPhaseDurationMs(ServerQueryPhase.QUERY_PROCESSING),
+ "Processed
RequestId:{},table:{},segments(queried/processed/matched/consuming)={}/{}/{}/{},"
Review comment:
There may be (are) scripts that use this log line to parse. Unless
absolutely needed, let us not change the case for requestId?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
