siddharthteotia commented on a change in pull request #5589:
URL: https://github.com/apache/incubator-pinot/pull/5589#discussion_r442522159
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java
##########
@@ -198,12 +198,13 @@ public void stop() {
long schedulerWaitMs =
timerContext.getPhaseDurationMs(ServerQueryPhase.SCHEDULER_WAIT);
if (queryLogRateLimiter.tryAcquire() || forceLog(schedulerWaitMs,
numDocsScanned)) {
- LOGGER.info(
- "Processed
requestId={},table={},segments(queried/processed/matched/consuming)={}/{}/{}/{},"
- +
"schedulerWaitMs={},totalExecMs={},totalTimeMs={},minConsumingFreshnessMs={},broker={},"
- + "numDocsScanned={},scanInFilter={},scanPostFilter={},sched={}",
- requestId, tableNameWithType, numSegmentsQueried,
numSegmentsProcessed, numSegmentsMatched,
- numSegmentsConsuming, schedulerWaitMs,
timerContext.getPhaseDurationMs(ServerQueryPhase.QUERY_PROCESSING),
+ LOGGER.info("Processed
requestId:{},table:{},segments(queried/processed/matched/consuming)={}/{}/{}/{},"
Review comment:
"=" is better for parsing out since ":" is also present in timestamps.
Made this consistent with log in BaseBrokerRequestHandler
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
