mcvsubbu commented on a change in pull request #5589:
URL: https://github.com/apache/incubator-pinot/pull/5589#discussion_r442382125
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java
##########
@@ -199,11 +199,13 @@ public void stop() {
if (queryLogRateLimiter.tryAcquire() || forceLog(schedulerWaitMs,
numDocsScanned)) {
LOGGER.info(
- "Processed
requestId={},table={},segments(queried/processed/matched/consuming)={}/{}/{}/{},"
- +
"schedulerWaitMs={},totalExecMs={},totalTimeMs={},minConsumingFreshnessMs={},broker={},"
- + "numDocsScanned={},scanInFilter={},scanPostFilter={},sched={}",
- requestId, tableNameWithType, numSegmentsQueried,
numSegmentsProcessed, numSegmentsMatched,
- numSegmentsConsuming, schedulerWaitMs,
timerContext.getPhaseDurationMs(ServerQueryPhase.QUERY_PROCESSING),
+ "Processed
RequestId:{},table:{},segments(queried/processed/matched/consuming)={}/{}/{}/{},"
+ +
"schedulerWaitMs:{},reqDeserMs:{},totalExecMs:{},resSerMs:{},totalTimeMs:{},minConsumingFreshnessMs:{},broker:{},"
Review comment:
let us stick to "name1=value1,name2=value2,....". (IOW comma-separtated
name=value, no other spaces).
My bad when I wrote "variables". I meant item names. For some reason, I
thought "schedulerWaitMs" was changed to "sched" May be I was mistaken.
Sorry to harp on this, but when we look through gazillion log lines scripts
help if the format is uniform.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
