siddharthteotia commented on pull request #5619: URL: https://github.com/apache/incubator-pinot/pull/5619#issuecomment-649302759
> Amazing work! > > We definitely need a backward compatibility test for segments. @kishoreg , there is no backward incompatibility here. The PR https://github.com/apache/incubator-pinot/pull/5510 actually results in double memory allocation (as explained above in the description) W.r.t tests for backward compatibility of raw index reader writer, we already have them. There are files checked in from prior versions to ensure current readers can read old versions. We have them for both compressed and uncompressed. I recently added more tests too. See VarByteChunkSingleValueWriterTest.java ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
