siddharthteotia commented on a change in pull request #5619:
URL: https://github.com/apache/incubator-pinot/pull/5619#discussion_r445814541



##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/MultiValueBlock.java
##########
@@ -47,6 +50,9 @@ public BlockDocIdSet getBlockDocIdSet() {
 
   @Override
   public BlockValSet getBlockValueSet() {

Review comment:
       @Jackie-Jiang , I am concerned about the invocation of this in 
multi-threaded scenario. From the code, it doesn't look like it will happen 
since each query will create it's own. Thoughts?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to