siddharthteotia commented on a change in pull request #5619:
URL: https://github.com/apache/incubator-pinot/pull/5619#discussion_r445844298
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/MultiValueBlock.java
##########
@@ -31,12 +31,15 @@
@SuppressWarnings("rawtypes")
public final class MultiValueBlock implements Block {
- private final BlockValSet _blockValSet;
+ private final SingleColumnMultiValueReader _reader;
+ private final FieldSpec.DataType _dataType;
+ private BlockValSet _blockValSet;
Review comment:
done
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/SingleValueBlock.java
##########
@@ -32,13 +32,14 @@
@SuppressWarnings("rawtypes")
public final class SingleValueBlock implements Block {
private final SingleColumnSingleValueReader _reader;
- private final BlockValSet _blockValSet;
+ private final FieldSpec.DataType _dataType;
+ private BlockValSet _blockValSet;
Review comment:
done
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/DataFetcher.java
##########
@@ -62,7 +62,7 @@ public DataFetcher(Map<String, DataSource> dataSourceMap) {
DataSource dataSource = entry.getValue();
_dictionaryMap.put(column, dataSource.getDictionary());
DataSourceMetadata dataSourceMetadata =
dataSource.getDataSourceMetadata();
- BlockValSet blockValueSet = dataSource.nextBlock().getBlockValueSet();
+ BlockValSet blockValueSet =
dataSourceMap.get(column).nextBlock().getBlockValueSet();
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
