chenboat commented on a change in pull request #5639:
URL: https://github.com/apache/incubator-pinot/pull/5639#discussion_r448601088
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/SegmentCompletionManager.java
##########
@@ -1068,16 +1069,28 @@ private int numReplicasToLookFor() {
_state = State.COMMITTING;
// In case of splitCommit, the segment is uploaded to a unique file name
indicated by segmentLocation,
// so we need to move the segment file to its permanent location first
before committing the metadata.
- if (isSplitCommit) {
+ // The committingSegmentDescriptor is then updated with the permanent
segment location to be saved in metadata
+ // store.
+ // The exception is when the server uses the Peer segment download
scheme, in such case, there is no need to
+ // move the segment.
+ if (isSplitCommit &&
!isPeerSegmentDownloadScheme(committingSegmentDescriptor)) {
Review comment:
got it. thank. good idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
